DM-31542: Allow writeFitsWithOptions for image/mask to select the options section #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Aug 30, 2021
python/lsst/afw/image/image/_mask.py
Outdated
| ---------- | ||
| dest : `str` | ||
| Fits file path to which to write the mask. | ||
| options : `lsst.daf.base.PropertySet |
python/lsst/afw/image/image/_mask.py
Outdated
| It must contain an `lsst.daf.base.PropertySet` with data for | ||
| ``lsst.afw.fits.ImageWriteOptions``. | ||
| item : `str`, optional | ||
| Item to read from the ``options`` `lsst.daf.base.PropertySet`. |
There was a problem hiding this comment.
You have mentioned the type of options multiple times...
Image and Mask previously always used an "image" section of the compression options. This made it impossible to reuse the compression settings from an Exposure without copying the relevant section to image. This change allows the section to be explicitly specified so that a user can declare that they want the variance settings to be applied. Mask is changed to always prefer "mask" section before falling back to "image".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image and Mask previously always used an "image" section of the
compression options. This made it impossible to reuse the compression
settings from an Exposure without copying the relevant section to
image. This change allows the section to be explicitly specified
so that a user can declare that they want the variance settings
to be applied. Mask is changed to always prefer "mask" section
before falling back to "image".