DM-29511: apply clang tidy cleanups #606
Conversation
There was a problem hiding this comment.
Looks good. I'm happy with all of these fixes except (possibly):
-
I'd like to try to make the range-based for conversion use
auto const &a little more often (see line comment). -
I'm not sure of the value of
[[nodiscard]]for us; I think it'll be visual noise for a lot of readers, and since we don't use return values for error propagation really at all, I don't think we're getting much. I can think of one big exception, but it's not relevant forafw: ingeomandsphgeom, we have a lot of classes with both in-place and returning versions of many operations (e.g.flipoperates in place,flippedreturns a new geometry), and[[nodiscard]]on the returning versions would be very nice. I don't feel very strongly about this, though, so if it's a pain to remove just that commit I don't mind if it gets merged as well.
apply clang-tidy fixes: modernize-use-nullptr modernize-use-emplace modernize-deprecated-headers modernize-use-using modernize-modernize-loop-convert modernize-use-equals-default modernize-use-default-member-init performance-implicit-conversion-in-loop performance-faster-string-find modernize-use-override modernize-make-shared
mwittgen
force-pushed
the
tickets/DM-29511
branch
from
fbcbe7d
to
f2ab5af
Compare
No description provided.