DM-31721: Fix exception catching for getPackageDir #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should use LookupError since that is compatible with C++ and Python implementations. Note that astrometry_net_data will never be found so this code looks suspect.
timj
force-pushed
the
tickets/DM-31721
branch
from
cc3cf31
to
4488686
Compare
timj
force-pushed
the
tickets/DM-31721
branch
from
6b925bb
to
4a6d05b
Compare
Using Utils.h was deprecated in 2018 with DM-10384.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should use LookupError since that is compatible with C++ and
Python implementations.
Note that astrometry_net_data will never be found so this code
looks suspect.