Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-30777: remove unused includes #608

Merged
merged 1 commit into from Sep 23, 2021
Merged

DM-30777: remove unused includes #608

merged 1 commit into from Sep 23, 2021

Conversation

mwittgen
Copy link
Contributor

No description provided.

andy-slac
andy-slac approved these changes Sep 22, 2021
View reviewed changes
Copy link

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK in general, though it feels like the tool removes too much in some cases. I tried to look through some files but there are too many of them. I guess if Jenkins is happy then it should be fine.

examples/image.cc Outdated Show resolved Hide resolved
examples/integrateExample.cc Show resolved Hide resolved
examples/lanczosKernel.cc Show resolved Hide resolved
examples/mask.cc Show resolved Hide resolved
examples/simpleConvolve.cc Show resolved Hide resolved
src/geom/Transform.cc Show resolved Hide resolved
src/image/Filter.cc Show resolved Hide resolved
src/math/detail/ConvolveWithInterpolation.cc Outdated Show resolved Hide resolved
src/math/detail/KernelImagesForRegion.cc Show resolved Hide resolved
src/table/AliasMap.cc Show resolved Hide resolved
@mwittgen mwittgen merged commit 5ddfab5 into master Sep 23, 2021
@mwittgen mwittgen deleted the tickets/DM-30777 branch September 23, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktlim ktlim ktlim left review comments

@TallJimbo TallJimbo TallJimbo left review comments

@andy-slac andy-slac andy-slac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mwittgen @ktlim @TallJimbo @andy-slac