DM-32055: Write util for calculating angle between wcses #611
Conversation
mfisherlevine
force-pushed
the
tickets/DM-32055
branch
2 times, most recently
from
e84e80c
to
b27f6f5
Compare
mfisherlevine
force-pushed
the
tickets/DM-32055
branch
from
b27f6f5
to
185d4dc
Compare
mfisherlevine
changed the title
mfisherlevine
force-pushed
the
tickets/DM-32055
branch
from
185d4dc
to
0ba9d55
Compare
python/lsst/afw/geom/skyWcs.py
Outdated
| @@ -99,5 +101,47 @@ def skyToPixelArray(self, ra, dec, degrees=False): | |||
|
|
|||
| return x.ravel(), y.ravel() | |||
|
|
|||
| def getRelativeRotationAngleFromWcs(self, wcs): | |||
There was a problem hiding this comment.
I know I suggested the name off the top of my head, but is Angle redundant? Leave it up to you if you think getRelativeRotationFromWcs() sounds okay.
There was a problem hiding this comment.
Is now getRelativeRotationToWcs() for anyone following.
There was a problem hiding this comment.
Is it "to" or "from"? There is a minus sign difference implied between the two names. It's worth thinking about which one is correct here.
There was a problem hiding this comment.
I changed the name (and the docs) precisely because of that difference, but it's also entirely possible that I got it wrong. Do you think it looks wrong, or were you just urging caution in general as they're imply different things (in which case I totally agree!)
There was a problem hiding this comment.
It was general caution. I didn't try to figure it out. If you thought about it, then that's probably good.
And I just now took the chance to think about it too, and I think this is right. It's the (counter-clockwise) rotation you need to apply to this one to get to the other one. So yeah, "to" seems like the right preposition.
There was a problem hiding this comment.
Great, thanks! I think this is all the more important now that it's a method that lives on the wcs itself.
mfisherlevine
force-pushed
the
tickets/DM-32055
branch
2 times, most recently
from
0e6730f
to
0a52c97
Compare
mfisherlevine
force-pushed
the
tickets/DM-32055
branch
from
0a52c97
to
526ceb5
Compare
No description provided.