DM-31254: Update polygon test and add explanation. #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
approved these changes
Nov 5, 2021
tests/test_polygon.py
Outdated
| disp.line((p1, p2)) | ||
| # Some computations of the image area have such large aliasing | ||
| # in boost::intersection that the precision required here is 0.025. | ||
| self.assertAlmostEqual( |
There was a problem hiding this comment.
Expressing this as assertFloatsAlmostEqual with rtol would allow you to get both areas printed in case of a failure, wouldn't it?
mwittgen
approved these changes
Nov 5, 2021
src/geom/polygon/Polygon.cc
Outdated
| @@ -121,7 +121,12 @@ void addSubSampledEdge(std::vector<LsstPoint>& vertices, // Vector of points to | |||
| /// @internal Calculate area of overlap between polygon and pixel | |||
| double pixelOverlap(BoostPolygon const& poly, int const x, int const y) { | |||
| std::vector<BoostPolygon> overlap; // Overlap between pixel and polygon | |||
| LsstBox const pixel(lsst::geom::Point2D(x - 0.5, y - 0.5), lsst::geom::Point2D(x + 0.5, y + 0.5)); | |||
| LsstBox const pixel(lsst::geom::Point2D((double) x - 0.5, (double) y - 0.5), | |||
There was a problem hiding this comment.
Maybe use C++ style static_cast<double>(x).
erykoff
force-pushed
the
tickets/DM-31254
branch
from
6d8630d
to
175b8c1
Compare
erykoff
force-pushed
the
tickets/DM-31254
branch
from
175b8c1
to
018c791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.