DM-32823: Change ds9 calls to use non-zero frame number #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
approved these changes
Dec 6, 2021
tests/test_ds9.py
Outdated
| @@ -36,9 +36,11 @@ | |||
| except Exception: | |||
| ds9 = None | |||
|
|
|||
| FRAME_NUM = 731 # largish, random number, unlikely to be in use by a user | |||
There was a problem hiding this comment.
This is an arbitrary number, not a random number.
There was a problem hiding this comment.
Lol, I'll fix that once Jenkins passes and then merge without rerunning, I think that's fine, and not worth restarting Jenkins for.
mfisherlevine
force-pushed
the
tickets/DM-32823
branch
from
2e7a2cb
to
5a53738
Compare
mfisherlevine
force-pushed
the
tickets/DM-32823
branch
from
5a53738
to
cef03f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.