Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-34621: Use image caches to satisfy PSF bbox checks, when possible. #635

Merged
merged 1 commit into from May 14, 2022

Conversation

TallJimbo
Copy link
Member

No description provided.

Copy link
Member

@arunkannawadi arunkannawadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Jim.

This kind of ties the result of doComputeBBox as the bbox of the kernelImage. Given that it's a virtual method in this base class, I wonder how it'd hold up if a derived class (incorrectly) implements it as a bounding box of its image. This is of course a hypothetical situation for now.

I also wonder if there'd be any (dis)advantage to just caching the bounding boxes right beside the cached (k)images, instead of getting the cached image first and then getting its bounding box.

@TallJimbo
Copy link
Member Author

Given that it's a virtual method in this base class, I wonder how it'd hold up if a derived class (incorrectly) implements it as a bounding box of its image. This is of course a hypothetical situation for now.

This is true, but I don't think it's avoidable; we just have to rely on derived classes getting it right when they override them.

I also wonder if there'd be any (dis)advantage to just caching the bounding boxes right beside the cached (k)images, instead of getting the cached image first and then getting its bounding box.

I think this would only pay off if bounding box calculations were both pretty expensive on their own (true at some level for CoaddPsf, but I'm not sure how much) and we're likely to have a lot of bounding box requests at a point before we get any PSF image requests at that point (I'm pretty confident this is not true).

@TallJimbo TallJimbo merged commit 2d02cc6 into main May 14, 2022
@TallJimbo TallJimbo deleted the tickets/DM-34621 branch May 14, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants