DM-35281: Avoid duplicate peak ID's #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Jun 28, 2022
tests/test_footprintMergeCatalog.py
Outdated
| fp1.makeSources(self.catalog1) | ||
|
|
||
| idFactory = afwTable.IdFactory.makeSimple() | ||
| table = afwTable.SourceTable.make(schema, idFactory) |
There was a problem hiding this comment.
Since you're re-using the idFactory name every time here, it might be clearer to just put the IdFactor.makeSimple() inside the SourceTable.make() call in each of these cases?
tests/test_footprintMergeCatalog.py
Outdated
| # The peak catalog may be non-contiguous, | ||
| # so add each peak individually | ||
| peaks = [peak.getId() for peak in src.getFootprint().peaks] | ||
| self.assertEqual(len(peaks), len(np.unique(peaks))) |
There was a problem hiding this comment.
How about self.assertEqual(sorted(peaks), sorted(set(peaks))? That would specify exactly which ones don't match.
tests/test_footprintMergeCatalog.py
Outdated
| del self.table | ||
|
|
||
| def assertUniqueIds(self, catalog): | ||
| """Ensure that all of the peak IDs in a single parent are unique |
There was a problem hiding this comment.
Period at end of sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.