DM-35457: Fix handling of FITS error messages passed to C++ exceptions #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwittgen
force-pushed
the
tickets/DM-35457
branch
from
b342c12
to
8d7e99a
Compare
timj
reviewed
Jul 29, 2022
src/fits.cc
Outdated
| cfitsioMsg[FLEN_ERRMSG-1] = char(0); // ensure termination | ||
| std::size_t len=strlen(cfitsioMsg); | ||
| for(std::size_t i=0;i<len;i++) | ||
| if(cfitsioMsg[i] < char(32)) cfitsioMsg[i] = '.'; |
There was a problem hiding this comment.
(I think my previous comment got rebased out).
I think isprint() as the test would be more explicit.
There was a problem hiding this comment.
Yes, ignore the previous version. isprint is clearly better.
mwittgen
force-pushed
the
tickets/DM-35457
branch
from
8d7e99a
to
11ed095
Compare
mwittgen
force-pushed
the
tickets/DM-35457
branch
from
11ed095
to
9383817
Compare
timj
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.