DM-35895: Use band for the dataId not filter #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gen3 uses band for coadds. If people want to retrieve by physical filter it would likely need a change in API or much more cleverness in trying to inspect the dataset type.
Now uses gen3
Gen3 knows that the dataId includes detector and so does not need to try many variants.
erykoff
approved these changes
Aug 15, 2022
| # replace with a local dataset | ||
| DATA_DIR = "/datasets/hsc/repo/rerun/RC/w_2018_22/DM-14547" | ||
| butler = Butler(inputs=DATA_DIR) | ||
| DATA_DIR = "/repo/main" |
There was a problem hiding this comment.
I don't think that /repo/main works anywhere ...
There was a problem hiding this comment.
It's meant to be an example. Also, K-T was pondering defining /repo/main as a butler alias at SLAC.
There was a problem hiding this comment.
Hmm. Nothing is going to work without a collections parameter either here or in the fromButler method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gen3 uses band for coadds. If people want to retrieve by
physical filter it would likely need a change in API
or much more cleverness in trying to inspect the dataset type.