DM-36762: Fix broken Spanset.asArray method #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
reviewed
Oct 27, 2022
tests/test_spanSets.py
Outdated
| @@ -440,6 +440,24 @@ def testSpanIteration(self): | |||
| self.assertEqual(len(span), len(points)) | |||
| self.assertEqual(points, [lsst.geom.Point2I(x, 4) for x in range(3, 9)]) | |||
|
|
|||
| def testAsArray(self): | |||
| spans = afwGeom.SpanSet(lsst.geom.Box2I(lsst.geom.Point2I(2, 3), | |||
There was a problem hiding this comment.
Black assures me that this would make more sense written this way:
spans = afwGeom.SpanSet(
lsst.geom.Box2I(lsst.geom.Point2I(2, 3), lsst.geom.Point2I(6, 7))
)
I think I agree, but I don't feel super strongly about it!
There was a problem hiding this comment.
Sure, I changed it. I don't like it written the way it was either, I just copied it from one of the tests above and didn't bother to reformat it.
fred3m
force-pushed
the
tickets/DM-36762
branch
from
1b6f906
to
476c807
Compare
fred3m
force-pushed
the
tickets/DM-36762
branch
from
476c807
to
74d4f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.