DM-37085: Add copyWith method to VisitInfo #669
Conversation
python/lsst/afw/image/_visitInfo.py
Outdated
| hasSimulatedContent = self.hasSimulatedContent | ||
|
|
||
| return VisitInfo( | ||
| exposureId=0, |
There was a problem hiding this comment.
Shouldn't that be exposureId=exposureId? And doesn't that then need an accompanying block above like all the others? Or am I missing something about that being special somehow?
There was a problem hiding this comment.
Oh, or are you saying that because it's a copy, it no longer corresponds to the original expId, and therefore must be zeroed out? If so, might be worth setting a more obviously suspicious value like -1, and either way, a comment to say that's why it's hard-coded to zero.
There was a problem hiding this comment.
Oh, this was me being lazy and just trying to make the tests work in time for the end of the day. The issue is that exposureId is deprecated (see https://github.com/lsst/afw/blob/main/python/lsst/afw/image/_visitInfo.py#L31-L35), so VisitInfo has a getExposureId method, but not an exposureId property. Fixed this and updated.
There was a problem hiding this comment.
Ah, gotcha OK, thanks.
squash me
fred3m
force-pushed
the
tickets/DM-37085
branch
from
21c85d7
to
69d7e23
Compare
No description provided.