DM-27547: stringify spatialCells #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Feb 6, 2023
python/lsst/afw/math/_spatialCell.py
Outdated
| f"status={self.getStatus().name}, rating={self.getCandidateRating()}") | ||
|
|
||
|
|
||
| SpatialCellCandidate.__repr__ = spatialCellCandidateRepr |
There was a problem hiding this comment.
Might want to use lsst.utils.continueClass for the content of this module.
There was a problem hiding this comment.
I was just continuing the pattern that had been set up, but you're right. I'll rework it.
|
|
||
| class SpatialCellImageCandidateTestCase(unittest.TestCase): | ||
|
|
||
| def setUp(self): | ||
| # To ensure consistency across tests: width/height are static members | ||
| # of SpatialCellImageCandidate, and tests can run in any order. |
There was a problem hiding this comment.
width/height are static members
😱 🙈
There was a problem hiding this comment.
I agree, but I'm not even thinking of attempting to fix that on this ticket.
Modify tests to behave properly with the class static height/weight members.
parejkoj
force-pushed
the
tickets/DM-27547
branch
from
1280743
to
a568e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.