Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39700: Remove inheritance from unary/binary_function #691

Merged
merged 1 commit into from Jun 20, 2023
Merged

DM-39700: Remove inheritance from unary/binary_function #691

merged 1 commit into from Jun 20, 2023

Conversation

mwittgen
Copy link
Contributor

No description provided.

erykoff
erykoff requested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more places that std::unary_function and std::binary_function are used in afw, particularly lsstGil.h and integrate.h that I can see with a search. (But these bits of code may be unused, we should clean them up or remove them.)

@erykoff
Copy link
Contributor

erykoff commented Jun 20, 2023

Still doesn't work; there are uses of binary_function in at least Pixel.h that need to be cleaned up, not just the unary_function.

@mwittgen
Copy link
Contributor Author

Wasn't pushed. Pushed now

@mwittgen mwittgen requested a review from erykoff June 20, 2023 17:40
erykoff
erykoff approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works on macos with 7.0.0dev and libcxx=16.

@mwittgen mwittgen merged commit c09b65a into main Jun 20, 2023
1 check passed
@mwittgen mwittgen deleted the tickets/DM-39700 branch June 20, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mwittgen @erykoff