DM-31707: Remove deprecated interfaces #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwittgen
force-pushed
the
tickets/DM-31707
branch
from
6cfb4f1
to
f1aee65
Compare
jmeyers314
approved these changes
Jul 12, 2023
python/lsst/afw/detection/_psf.cc
Outdated
| ); | ||
| return psf.getLocalKernel(); | ||
| } | ||
| ); | ||
| // End deprecated default position argument overloads. |
There was a problem hiding this comment.
Should probably get rid of this line too
There was a problem hiding this comment.
I think you can get rid of all the py::overload_cast<> templates now and just use, e.g.,
cls.def("computeBBox",
&Psf::computeBBox,
"position"_a,
"color"_a = image::Color()
);
mwittgen
force-pushed
the
tickets/DM-31707
branch
from
f1aee65
to
1cfb15d
Compare
mwittgen
force-pushed
the
tickets/DM-31707
branch
from
1cfb15d
to
fdfdf25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.