DM-40451: Update MultibandExposure.computePsfImage #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fred3m
force-pushed
the
tickets/DM-40451
branch
from
420b2c0
to
d2d9071
Compare
cmsaunders
approved these changes
Sep 19, 2023
| from .._image._multiband import tripleFromSingles, tripleFromArrays, makeTripleFromKwargs | ||
| from .._maskedImage import MaskedImage | ||
|
|
||
|
|
||
| class IncompleteDataError(Exception): | ||
| """The PSF could not be computed due to incomplete data | ||
|
|
||
| Attributes |
There was a problem hiding this comment.
All the __init__ arguments except bands become attributes, so maybe you don't want a Parameters section that repeats all of this, plus describes bands, but I think bands needs some documentation. I'm not sure what the convention is here.
There was a problem hiding this comment.
Since our convention is to include Parameters in the class docstring, not the __init__ docstring, I think that it makes sense to add a Parameters sections with only bands, since the preceding Attributes section describes the other parameters.
This updates the `MultibandExposure.computePsf<Kernel>Image` methods to return a `MultibandImage`. It also adds the partial PSF to the `IncompleteDataError` so that users who try...except the error can obtain the PSF in all of the bands that were able to construct a PSF image.
fred3m
force-pushed
the
tickets/DM-40451
branch
from
d2d9071
to
4865523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
MultibandExposure.computePsf<Kernel>Imagemethods to return aMultibandImage. It also adds the partial PSF to theIncompleteDataErrorso that users who try...except the error can obtain the PSF in all of the bands that were able to construct a PSF image.