DM-41012: Check for empty spanset prior to trying to transform it #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Oct 4, 2023
src/geom/SpanSet.cc
Outdated
| @@ -848,6 +848,11 @@ std::shared_ptr<SpanSet> SpanSet::transformedBy(lsst::geom::AffineTransform cons | |||
| } | |||
|
|
|||
| std::shared_ptr<SpanSet> SpanSet::transformedBy(TransformPoint2ToPoint2 const& t) const { | |||
| // Check if it's an empty bounding box | |||
There was a problem hiding this comment.
Suggested change
| // Check if it's an empty bounding box | |
| // If the SpanSet is empty, its bounding box corners are not meaningful and cannot be transformed. |
(but line-wrapped)
There was a problem hiding this comment.
As an aside, I think we should make Box2I.getCorners raise an exception if the box is empty. Not suggesting it go on this ticket.
erykoff
force-pushed
the
tickets/DM-41012
branch
from
fef4809
to
7a34743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.