DM-30535-v24: Update multi-band APIs and conversion to arrays #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful downstream to have methods for converting spans and footprints to numpy arrays. This commit moves many methods that were available as stand-alone functions in meas_extensions_scarlet and implements them here where they belong.
fred3m
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Everything looks fine except that this only includes a subset of the changes required for DM-40451 to work properly. I'm not sure about the current back-porting procedure, but I worry that only backporting one ticket at a time will lead to breakages along the way. Wouldn't it be easier to have a single ticket to backport the entire chain of tickets required to implement DM-40451 (and the bug fixes that followed)?
|
I back ported all tickets accumulatively, stacked MRs, and did run the compounded in CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.