Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-6391: Add centroids plotting for catalogs #723

Merged
merged 1 commit into from Jan 10, 2024
Merged

Conversation

parejkoj
Copy link
Contributor

@parejkoj parejkoj commented Jan 9, 2024

No description provided.

Copy link
Contributor

@PaulPrice PaulPrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks!

@@ -644,6 +644,26 @@ def erase(self):
"""
self._impl._erase()

def centroids(self, catalog, symbol=None, *args, **kwargs):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't you do symbol="o"? It's not modifiable, like a list, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I was dumb. Good call!

"""Draw the sources from a catalog at their pixel centroid positions
as given by ``getX()`` and ``getY()``.

See `dot` for explanation of ``symb`` and available kwargs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's spelled symbol in the function def.
Make it more explicit that args, kwargs are passed to dot.

@parejkoj parejkoj force-pushed the tickets/DM-6391 branch 2 times, most recently from e5af194 to de97699 Compare January 10, 2024 21:00
@parejkoj parejkoj merged commit 8c70369 into main Jan 10, 2024
2 checks passed
@parejkoj parejkoj deleted the tickets/DM-6391 branch January 10, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants