Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42445: afw display cleanups and new image() method #724

Merged
merged 5 commits into from Mar 4, 2024

Conversation

parejkoj
Copy link
Contributor

No description provided.

Copy link

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few comments about docstrings. This looks like a good first step to modernizing and strengthening the interface.

python/lsst/afw/display/interface.py Outdated Show resolved Hide resolved
python/lsst/afw/display/interface.py Outdated Show resolved Hide resolved
python/lsst/afw/display/interface.py Outdated Show resolved Hide resolved
python/lsst/afw/display/interface.py Show resolved Hide resolved
`display.image` is is much more introspectable.
Display-specific arguments should all be passed as kwargs.
Add punctuation, reformat to 79char, add clarifications/missing parameters.
Copy link

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now.

@parejkoj parejkoj merged commit fe91617 into main Mar 4, 2024
2 checks passed
@parejkoj parejkoj deleted the tickets/DM-42445 branch March 4, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants