DM-43416: Fix warning in bbox_contains_sky_coords #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, bbox_contains_sky_coords would try to convert NaN or infinite pixel values to integers, emitting a warning and risking undefined behavior. This commit does not address the question of _how_ fractional pixels should be converted to integers, as that depends on the counterintuitive behavior of Box.
isullivan
approved these changes
Apr 29, 2024
This commit reduces the number of calculations in the case that many points like far outside the bounding box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in coordinate checks that attempted to convert NaN or infinite values to integers. The bug was exposed by unit tests, but went unnoticed because it only caused a warning instead of an error.