Add updateRefCentroids and updateSourceCoords #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.assertPairsNearlyEqual(refCentroid, self.crpix) | ||
|
|
||
| # coord should not be changed | ||
| self.assertPairsNearlyEqual(self.refCat[0].get(self.refCoordKey), self.crval, maxDiff=0) |
There was a problem hiding this comment.
Shouldn't you be able to use assertEqual here, since coord really shouldn't be touched at all?
There was a problem hiding this comment.
maxDiff=0 has the same effect, and I don't know if Coord supports operator==
There was a problem hiding this comment.
Ah, right, it's an afw object. Can you try it with equal and see what happens? I see "nearlyEqual" and think "something could have gotten jittered a bit", even with the maxDiff.
There was a problem hiding this comment.
Will do. I just checked and Coord does support operator== so this ought to work.
Add two utility functions to lsst.afw.table: updateRefCentroids and updateSourceCoords. Add a unit test for these functions testTableUtils.py (since the functions are defined in new module lsst.afw.table.utils)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two utility functions to lsst.afw.table:
updateRefCentroids and updateSourceCoords.
Add a unit test for these functions testTableUtils.py
(since the functions are defined in new module lsst.afw.table.utils)