Tickets/dm 1218 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // distiguishing between two cases where the field can't be found: | ||
| // - if the alias points to an invalid field, we should throw an exception. | ||
| // - if the alias simply isn't defined, we should just reset the slot with invalid keys | ||
| class MeasFieldNameGetter { |
There was a problem hiding this comment.
It might help readability to be more specific about exactly where the throwing, etc, is supposed to happen. Being unfamiliar with the code, I was confused to note that you seemed to be catching and handling exceptions below rather than raising them. Took me a moment to realise where the exception you're referring to here was coming from.
Prior to this change, slots were only allowed to be undefined when the SourceTable is constructed, and removing slot aliases caused an exception to be thrown. Now, removing a slot alias simply resets that slot.
mjuric
force-pushed
the
tickets/DM-1218
branch
from
01f4bf7
to
286e5d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.