Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-7886: Use astropy.io.fits #3

Merged
merged 4 commits into from
Jul 11, 2018
Merged

DM-7886: Use astropy.io.fits #3

merged 4 commits into from
Jul 11, 2018

Conversation

timj
Copy link
Member

@timj timj commented Jul 6, 2018

No description provided.

@timj timj requested a review from r-owen July 6, 2018 21:49
@timj timj changed the title DM-7866: Use astropy.io.fits DM-7886: Use astropy.io.fits Jul 6, 2018
r-owen
r-owen approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine but I suggest deleting this script entirely. We have no remaining data in afwdata in the old format that requires conversion and I would be amazed if we had any anywhere else.

@timj timj merged commit e3096bf into master Jul 11, 2018
@ktlim ktlim deleted the tickets/DM-7886-afwdata branch August 25, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-owen r-owen r-owen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @r-owen