DM-25208: Fix broken test in lsst/alert_packet master #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps avoid them getting listed in diffs, which is too messy to be useful.
spenczar
force-pushed
the
tickets/DM-25208
branch
from
dda4707
to
c3615d8
Compare
jdswinbank
approved these changes
Jul 7, 2020
python/lsst/alert/packet/schema.py
Outdated
| @@ -174,6 +174,10 @@ def __init__(self, schema_definition): | |||
| self.definition = resolve_schema_definition(schema_definition) | |||
| fastavro.schema._schema.SCHEMA_DEFS.clear() | |||
|
|
|||
|
|
|||
| def __eq__(self, other): | |||
| return self.definition == other.definition | |||
There was a problem hiding this comment.
This looks pretty similar to
...?There was a problem hiding this comment.
It sure does, doesn't it. I don't know why a particular test had been failing intermittently, then, but it doesn't seem to fail anymore.
There was a problem hiding this comment.
Incidentally, today I learned that you can declare a method twice inside one class. Why on earth is that allowed? Ah, Python.
spenczar
force-pushed
the
tickets/DM-25208
branch
from
c3615d8
to
e71ddd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
DM-25208
There were several issues:
Schema equality checks weren't quite right. I needed to add a(revealed in review to be redundant)__eq__method to them.Along the way, I'm marking .avro files as "binary" so they don't show up in diffs as a bunch of garbage.