DM-26175: Require fastavro<0.24 for pip installations #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastavro v0.24 removes the SCHEMA_DEFS global variable. This was always part of a private API, so we shouldn't really have been messing with it, but that removal breaks alert_packet. A future revision should remove any references to SCHEMA_DEFS. See also: fastavro/fastavro#451
jdswinbank
approved these changes
Jul 31, 2020
|
Oh, I just plan to lock down versions for now; adopting v0.24 might take some thinking. I thought the rest of the story would be fixing the dependency pinning for stack builds. We can talk about that more on the Jira ticket, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one part of DM-26175, it's not the whole story.