Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-28768: Add compatibility with fastavro>=1.2 #24

Merged
merged 1 commit into from Feb 23, 2021
Merged

DM-28768: Add compatibility with fastavro>=1.2 #24

merged 1 commit into from Feb 23, 2021

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Feb 23, 2021

Note that resolve_schema_definitions() is not needed with fastavro version 1.2
and greater.

@erykoff
Add compatibility with fastavro>=1.2
9a9a5ec 
Note that resolve_schema_definitions() is not needed with fastavro version 1.2
and greater.
spenczar
spenczar approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@spenczar spenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in slack, this looks good.

@erykoff erykoff merged commit bd80f2f into master Feb 23, 2021
@erykoff erykoff deleted the tickets/DM-28768 branch February 23, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spenczar spenczar spenczar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erykoff @spenczar