DM-39756: Switch from pkg_resources to importlib.resources #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit worried about testing. The actions don't run the tests from what I can see and the tests fail for me if I run them locally. They fail for me on |
pkg_resources is deprecated. Change some interfaces to context managers to reflect the fact that package resources can come from a zip archive.
timj
force-pushed
the
tickets/DM-39756
branch
3 times, most recently
from
48eb8df
to
c2fde43
Compare
|
@bsmartradio this PR is ready for you to review. |
bsmartradio
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that resources can, in some rare cases, be inside zip files, I have implemented this as context managers rather than directly returning the paths. This required some tweaking in other places but @ebellm tells me this is an internal API.