DM-39938: Replace pkg_resources with importlib.resources #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API here is possibly dangerous in that resources can refer to ZIP files which might lead to the file path being returned to a temporary file that will be deleted. In all our common scenarios this is not an issue but a real fix would be to allow a URI to be returned that can be resolved later.
Does not use ResourcePath in order to minimize dependencies.
ebellm
approved these changes
Aug 29, 2023
The from_uri() method is complicated by fastavro requiring that all referenced schemas be available locally.
ebellm
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API here is possibly dangerous in that resources can refer to ZIP files which might lead to the file path being returned to a temporary file that will be deleted.
In all our common scenarios this is not an issue but a real fix would be to allow a URI to be returned that can be resolved later.
In particular ap_association should be using a URI and then internally resolving it with
lsst.resources.ResourcePath.