Skip to content

Commit

Permalink
Use intended column name for CircAp12 plots
Browse files Browse the repository at this point in the history
Any intended use for the "parameters" definitions are not being
taken advantage of and led to an incorrect column to be used for
one set of sky plots.  The safest option for now is to get rid
of the "parameters" in favor of explicitly listing the column
name (this way it should be easier to spot the incorrect use
of "i_ap09Flux" for a plot explicitly labeled as plot_CircAp12_*
that is being fixed here).
  • Loading branch information
laurenam committed May 19, 2022
1 parent f55fc45 commit f62f7f4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
5 changes: 1 addition & 4 deletions pipelines/coaddQAPlots.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
description: Make coadd plots for QA
parameters:
CoaddApFluxName: "i_ap09Flux"
band: i
tasks:
# Make a plot showing the difference between the aperture 12 magnitude and the PSF magnitude.
# This plot shows the on sky distribution of these values for stars.
plot_CircAp12_sub_PSF_meas_sky_stars:
class: lsst.analysis.drp.skyPlot.SkyPlotTask
config:
axisActions.zAction: MagDiff
axisActions.zAction.col1: parameters.CoaddApFluxName
axisActions.zAction.col1: "i_ap12Flux"
axisActions.zAction.col2: "i_psfFlux"
connections.plotName: CircAp12_sub_PSF_meas_stars_i
selectorActions.flagSelector: CoaddPlotFlagSelector
Expand Down
5 changes: 1 addition & 4 deletions pipelines/visitQAPlots.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,14 @@ description: |
For visit level plots the bands needs to be set to [""] to allow the code to be reused between
the coadd level tables, which have band_ prepended to their column names, and the visit level
tables which do not.
parameters:
VisitApFluxName: "ap12Flux"
band: i
tasks:
# Make a plot showing the difference between the aperture 12 magnitude and the PS magnitude.
# This plot shows the on sky distribution of these values for stars.
plot_CircAp12_sub_PS_meas_sky_stars_visit:
class: lsst.analysis.drp.skyPlotVisit.SkyPlotVisitTask
config:
axisActions.zAction: MagDiff
axisActions.zAction.col1: parameters.VisitApFluxName
axisActions.zAction.col1: "ap12Flux"
axisActions.zAction.col2: "psfFlux"
connections.plotName: CircAp12_sub_PS_meas_stars
selectorActions.flagSelector: VisitPlotFlagSelector
Expand Down

0 comments on commit f62f7f4

Please sign in to comment.