DM-33966: Create PSF size residual plots #17
Conversation
pipelines/visitQAEllipPlots.yaml
Outdated
| @@ -270,6 +270,29 @@ tasks: | |||
| from lsst.analysis.drp.calcFunctors import CalcShapeSize | |||
| from lsst.pipe.tasks.dataFrameActions import SubtractColumns | |||
|
|
|||
| plot_shapeSizeResidsDiff_scatter_visit: | |||
There was a problem hiding this comment.
Would plot_shapeSizeResidDiff_scatter_visit make more sense here?, i.e., not plural?
There was a problem hiding this comment.
I have changed the name of the action to FractionalDifferenceColumns. Perhaps, I could rename this to plot_shapeSizeFractionalDiff_scatter_visit?
pipelines/visitQAEllipPlots.yaml
Outdated
| axisActions.yAction: FractionalResidualColumns | ||
| axisActions.yAction.colA: CalcShapeSize | ||
| axisActions.yAction.colA.colXx: "ixx" | ||
| axisActions.yAction.colA.colYy: "iyy" | ||
| axisActions.yAction.colB: CalcShapeSize | ||
| axisActions.yAction.colB.colXx: "ixxPSF" | ||
| axisActions.yAction.colB.colYy: "iyyPSF" |
There was a problem hiding this comment.
Do you also need to specify ixy and ixyPSF here too? I don't know how the FractionalResidualColumns action works, so maybe not needed?
There was a problem hiding this comment.
I don't follow this question. The quantity plotted is the measured size from ixx, iyy etc. and the PSF shape from ixxPSF and iyyPSF etc. So you need both measured and PSF quantities.
There was a problem hiding this comment.
Fair enough! From our discussion yesterday, I wasn't sure if you also need ixy. If not, that's fine!
There was a problem hiding this comment.
Good catch, Lee! I have specified colXy now, which was defaulting to ixy in both places.
| selectorActions.SnSelector.bands: [""] | ||
| selectorActions.SnSelector.fluxType: "psfFlux" | ||
| selectorActions.SnSelector.threshold: 10 | ||
| axisLabels: {"x": "PSF Magnitude (mag)", "mag": "PSF Magnitude (mag)", |
There was a problem hiding this comment.
Is the mag entry in this dict required, as it seems to be a repeat of x?
There was a problem hiding this comment.
This follows from axisLabels in other plots. I don't understand why mag and x entries are required when the string appears exactly once in the plot. This will be addressed in DM-33971 as well.
There was a problem hiding this comment.
On second thoughts, I think mag entry is associated with the stats that appears on the bottom right corner of the plot.
| selectorActions.SnSelector.fluxType: "psfFlux" | ||
| selectorActions.SnSelector.threshold: 10 | ||
| axisLabels: {"x": "PSF Magnitude (mag)", "mag": "PSF Magnitude (mag)", | ||
| "y": "Fractional shape difference (ixx - ixxPSF)"} |
There was a problem hiding this comment.
Just spoke with you about this label only referencing ixx, but realize that this will be addessed in DM-33971, so that's okay.
arunkannawadi
force-pushed
the
tickets/DM-33966
branch
from
e1a2fc1
to
b645315
Compare
No description provided.