New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-34309: Make tract-level PSF ellipticity plots #33
Conversation
from lsst.analysis.drp.calcFunctors import CalcE2 | ||
|
||
plot_shapeSize_scatter: | ||
# Plot a scatter plot of the values of (ixx*iyy - ixy^2)^(1/4) a measurement of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with this particular size measure - can you document it somewhere (i.e. if it's a weak lensing thing, or something from DES, cite the relevant paper)? That probably belongs in Notes for the CalcShapeSize action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is more of a GalSim thing, AFAIK. I've expanded the docstring for CalcShapeSize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're just talking about the expression in this comment, it's the same quantity we call "determinant radius".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... good point. But I don't think we've documented our naming conventions anywhere, have we? This GalSim function does so fairly well, though (more so than the hsm one, I think): https://galsim-developers.github.io/GalSim/_build/html/_modules/galsim/gsobject.html#GSObject.calculateMomentRadius
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have defined size precisely anywhere. I'd hope that the fractional residual quantities are much less sensitive to the exact definition though. For that matter, there are at least 2 different definitions of ellipticities and we don't define them clearly either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DM-34402 will add options to specify what definition of size and ellipticity to use (the default option would correspond to whatever they are now). And that could be one place where we define these consistently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we do have the TraceRadius
and DeterminantRadius
somewhere in our documentation. https://pipelines.lsst.io/v/v16-0/py-api/lsst.afw.geom.Quadrupole.html
53e8983
to
2100a92
Compare
Creates the plots requested in the metrics monitoring meeting
https://confluence.lsstcorp.org/display/DM/DRP+Metrics+Monitoring+2022-03-21