DM-34692: Fix band list for CoaddPlotFlag & Sn Selectors in coaddQAEllip pipeline #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default for the bands list is already ["i"] for the SnSelector, so it should not be included here. On the other hand, the default for the CoaddPlotFlagSelector is ["g", "r", "i", "z", "y"] and the plots will end up empty if not all of these bands are present (even though only the i band is being plotted), so these do need to be overridden here. This was noticed when running ci_hsc_gen3 which only includes r and i band data, so plots for this pipeline were all empty.
Added missing entry to __all__ and reordered entries to match their order of appearance in the file.
arunkannawadi
approved these changes
May 10, 2022
| @@ -1,5 +1,6 @@ | |||
| __all__ = ("FlagSelector", "PsfFlagSelector", "StarIdentifier", "GalaxyIdentifier", "UnknownIdentifier", | |||
| "CoaddPlotFlagSelector", "BaseSNRSelector", "SnSelector") | |||
| __all__ = ("FlagSelector", "PsfFlagSelector", "BaseSNRSelector", "SnSelector", | |||
There was a problem hiding this comment.
I'm not quite sure about exposing BaseSNRSelector here. It doesn't seem to be used anywhere(?) and if it is used, it would be to define other SNR selectors.
There was a problem hiding this comment.
I noticed that it is unused too and plan to address that on another ticket (I first want to check with the original author that removing it is the right thing to do). Since it was already in the list, I'll leave it as is here and deal with it on the removal ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.