DM-33123: Calculate RhoStatistics as part of regular QA #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config contains fields that correspond to various keyword arguments that can be passed on to treecorr.BinnedCorr2 and its derived classes such as GGCorrelation, KKCorrelation etc. used in Rho statistics calculations. The necessity to define a new classs instead of using DictField is to i) validate the config up front ii) allow mixed types and complete control over treecorr configuration.
The reason to not add this to visitQAEllipPlots.yaml is that, running coadds on visit-levels is much more time consuming than all other visit-level plots combined. A stand-alone pipeline is provided so plots can be generated on a need-to-see basis.
The documentation of the ``validate`` method in the parent class asserts that it raises ``FieldValidationError`` when misconfigured. Thus, instances of ``ValueError`` raises must be replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is attempt 2 at merging rho statistics after attempt 1 in #35 and reverting it later in #42