DM-34908: Consolidate task defaults and pipeline overrides #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a potential clash/conflict with the dataSelector whose name is SnSelector.
Many config settings were identical for all visit/coadd plots and were being set for each plot definition in the associated pipelines. Setting the defaults in the tasks allows for much simplified plot definitions in the pipelines. This also makes use of some interdependencies to avoid configs getting out of sync (in particular for the axis labels which are based on set parameters).
It is very useful to know what flavor of flux (e.g. psfFlux) was used in the signal-to-noise thresholding, so we now label the S/N flux type on the plot along with the threshold.
There is no plot interactivity required for these tasks, and not explicitly defaulting to Agg can lead to failures if the environment from which the pipelines are run changes underneath you. Forcing the backend to Agg thus guards against such situations.
Use latex math formula formatting and ensure consistency between configs and labels.
This includes cleaning up the star selection and adds a S/N selector (which defaults to S/N_PSF > 100) to better match the selecions in the scatter plots in coaddAQEllipPlots.yaml pipeline.
There was some inhomogeneity in referring to the point spread function as PS or PSF. The latter is preferred, so all instances of the former are updated here.
In particular, remove all tier 2 and tier 3 plots from coaddQAPlot.yaml and coaddQAEllipPlot.yaml and move them into a new coaddQAPlots_tier2_3.yaml that is not meant to be run in regular production. In order to access them, a pipelines/HSC/analysis_drp_plots_tier2_3.yaml is also being added to the drp_pipe repo.
Without these flags, it was possible for CModel NaN's to sneak in, so some plots were failing.
laurenam
force-pushed
the
tickets/DM-34908
branch
from
f08fe57
to
fff4164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.