DM-41027: Fix potential infinite loop in analysis_drp colorColorFitPlot #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
reviewed
Oct 23, 2023
| minPointsForFit = pexConfig.Field( | ||
| doc="Minimum number of valid objects to bother attempting a fit.", | ||
| dtype=int, | ||
| default=5, |
There was a problem hiding this comment.
Does this need to be validated as > 0?
There was a problem hiding this comment.
Good idea. I made it a RangeField and gave it min=1.
| @@ -305,10 +330,11 @@ def colorColorFitPlot(self, catPlot, plotInfo, fitParams): | |||
| SNsUsed = (catPlot[SNBand + "_" + plotInfo["SNFlux"]].values[fitPoints] | |||
There was a problem hiding this comment.
Is it possible for SNsUsed to be empty? I imagine the fit likely would have failed in that case, but if there's a chance it would keep going and result in an infinite loop again, maybe an explicit check would be worthwhile.
There was a problem hiding this comment.
Another good idea. I put in a check on len(fitParams["fitPoints"]) above with:
if len(fitParams["fitPoints"]) < 1:
raise ValueError("No fitPoints for {}".format(dataId))
Also fixes a bug resulting in the wrong bands being used to calculate the effective magnitude maximum threshold.
laurenam
force-pushed
the
tickets/DM-41027
branch
from
a38d183
to
7dac2bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.