Fix mypy linting errors

lsst · Aug 2, 2022 · bb118f0 · bb118f0
1 parent 1101645
commit bb118f0
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/python/lsst/analysis/tools/actions/scalar/scalarActions.py b/python/lsst/analysis/tools/actions/scalar/scalarActions.py
@@ -109,6 +109,7 @@ def getInputSchema(self, **kwargs) -> KeyedDataSchema:
         return ((self.vectorKey.format(**kwargs), Vector),)
 
     def __call__(self, data: KeyedData, **kwargs) -> Scalar:
+        values: Vector
         mask = self.getMask(**kwargs)
         values = data[self.vectorKey.format(**kwargs)][mask]
         values = values[np.logical_not(np.isnan(values))]

diff --git a/python/lsst/analysis/tools/actions/vector/selectors.py b/python/lsst/analysis/tools/actions/vector/selectors.py
@@ -41,10 +41,11 @@
 import numpy as np
 from lsst.pex.config import Field
 from lsst.pex.config.listField import ListField
-from lsst.pipe.tasks.configurableActions import ConfigurableActionStructField
 
 from ...interfaces import KeyedData, KeyedDataSchema, Vector, VectorAction
 
+# from lsst.pipe.tasks.configurableActions import ConfigurableActionStructField
+
 
 class FlagSelector(VectorAction):
     """The base flag selector to use to select valid sources for QA"""
@@ -382,6 +383,17 @@ def getInputSchema(self) -> KeyedDataSchema:
         return ((self.vectorKey, Vector),)
 
     def __call__(self, data: KeyedData, **kwargs) -> Vector:
+        # bands: Union[tuple | None]
+        # match kwargs:
+        #    case {"band": band}:
+        #        bands = (band,)
+        #    case {"bands": bands} if not self.bands:
+        #        bands = bands
+        #    case _ if self.bands:
+        #        bands = tuple(self.bands)
+        #    case _:
+        #        bands = None
+        bands: Optional[tuple[str, ...]]
         match kwargs:
             case {"band": band}:
                 bands = (band,)
@@ -395,5 +407,5 @@ def __call__(self, data: KeyedData, **kwargs) -> Vector:
             mask = np.in1d(data[self.vectorKey], bands)
         else:
             # No band selection is applied, i.e., select all rows
-            mask = np.full(len(data[self.vectorKey]), True)
+            mask = np.full(len(data[self.vectorKey]), True)  # type: ignore
         return cast(Vector, mask)
diff --git a/python/lsst/analysis/tools/analysisMetrics/photometricRepeatabilityMetrics.py b/python/lsst/analysis/tools/analysisMetrics/photometricRepeatabilityMetrics.py
@@ -22,8 +22,6 @@
 
 __all__ = ("StellarPhotometricRepeatabilityMetric",)
 
-from astropy import units as u
-
 from ..actions.scalar.scalarActions import FracThreshold, MedianAction
 from ..actions.vector import (
     BandSelector,