DM-39143: Implement script for uploading free metrics to Sasquatch #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-39143
branch
2 times, most recently
from
73a318d
to
011be80
Compare
The script will eventually allow upload of lsst.verify metrics as if they were analysis_tools metrics, providing backward-compatibility. This commit provides no functionality, only a trivial command-line parser and some auto-generated documentation.
This function converts standalone lsst.verify metrics into MetricBundles for upload. To avoid schema compatibility problems, each metric is assigned a unique action ID, even though this makes later analysis more difficult.
kfindeisen
force-pushed
the
tickets/DM-39143
branch
from
011be80
to
c772cca
Compare
The uploading is delegated to SasquatchDispatcher, with arguments formatted to be unique per-metric, where practical.
This argument is analogous to dispatch_verify.py --test, and makes testing accessible even to users who can't find the lsst.debug namespace.
This argument makes it possible to selectively upload metrics from a given collection.
kfindeisen
force-pushed
the
tickets/DM-39143
branch
from
c772cca
to
95bfbd1
Compare
afausti
approved these changes
May 24, 2023
| help="ISO8601 formatted datetime in UTC for the Job creation date, " | ||
| "e.g. 2021-06-30T22:28:25Z. If not provided, the run time or current " | ||
| "time is used.", | ||
| ) |
This argument is copied directly from dispatch_verify.py; it is the only optional argument that is also supported by SasquatchDispatcher.
The types in the docs have been brought up to date with the code, and some style errors have been fixed.
kfindeisen
force-pushed
the
tickets/DM-39143
branch
from
95bfbd1
to
4faafb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new script,
verify_to_sasquatch.py, that provides backwards-compatibility support forlsst.verifymetrics persisted directly to a Butler repository. The script implements functionality similar todispatch_verify.py, but backed bySasquatchDispatcher.