DM-39332: Fix the PF1 metric to be threshold relative to mean #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr525
reviewed
Jul 27, 2023
| @@ -536,7 +541,7 @@ def _calcStats(self, data): | |||
| mad = sigmaMad(data) | |||
| return num, med, mad | |||
|
|
|||
| def _addReferenceLines(self, ax, panel, panel_range, legend_font_size=7): | |||
| def _addReferenceLines(self, ax, panel, panel_range, meds, legend_font_size=7): | |||
There was a problem hiding this comment.
Should meds be a kwarg? Looks like it is optional later.
There was a problem hiding this comment.
I think it makes more sense to keep it a required input. Even though it is only used if the refRelativeToMedian flag is set, I'd rather be sure it's there when that flag is set than have an error when the flag is set and meds is not passed.
jeffcarlin
force-pushed
the
tickets/DM-39332
branch
from
1e1c182
to
efe4c1e
Compare
|
Jenkins has successfully built at https://rubin-ci.slac.stanford.edu/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/97/pipeline, so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket makes the PF1 metric calculation ("stellarPhotRepeatOutlierFraction") use a threshold relative to the median as defined in the SRD, rather than taking a simple threshold in rms. It involved changing the ScalarAction and HistPlot.