DM-35632: Port CModel PSFmag gal sky plot to analysis tools

python/lsst/analysis/tools/actions/plot/colorColorFitPlot.py

@@ -199,7 +199,7 @@ def makePlot(
 
         # Add some useful information to the plot
         bbox = dict(alpha=0.9, facecolor="white", edgecolor="none")
-        medMag = np.median(cast(Vector, mags))
+        medMag = np.nanmedian(cast(Vector, mags))
 
         # TODO: GET THE SN FROM THE EARLIER PREP STEP
         SN = "-"
@@ -318,9 +318,9 @@ def makePlot(
         # Add a histogram
         axHist.set_ylabel("Number")
         axHist.set_xlabel("Distance to Line Fit")
-        medDists = np.median(dists)
-        madDists = sigmaMad(dists)
-        meanDists = np.mean(dists)
+        medDists = np.nanmedian(dists)
+        madDists = sigmaMad(dists, nan_policy="omit")
+        meanDists = np.nanmean(dists)
 
         axHist.set_xlim(meanDists - 2.0 * madDists, meanDists + 2.0 * madDists)
         lineMedian = axHist.axvline(medDists, color="k", label="Median: {:0.3f}".format(medDists))

python/lsst/analysis/tools/actions/plot/plotUtils.py

@@ -472,7 +472,7 @@ def extremaSort(xs):
     ids : `np.array`
     """
 
-    med = np.median(xs)
+    med = np.nanmedian(xs)
     dists = np.abs(xs - med)
     ids = np.argsort(dists)
     return ids

python/lsst/analysis/tools/actions/plot/scatterplotWithTwoHists.py

@@ -465,8 +465,8 @@ def _scatterPlot(
 
                 for (i, xEdge) in enumerate(xEdgesPlot):
                     ids = np.where((xs < xEdge) & (xs > xEdges[i]) & (np.isfinite(ys)))[0]
-                    med = np.median(ys[ids])
-                    sigMad = sigmaMad(ys[ids])
+                    med = np.nanmedian(ys[ids])
+                    sigMad = sigmaMad(ys[ids], nan_policy="omit")
                     meds[i] = med
                     sigMads[i] = sigMad
                     threeSigMadVerts[i, :] = [xEdge, med + 3 * sigMad]
@@ -619,7 +619,7 @@ def _scatterPlot(
             plotMed = np.nanmedian(cast(Vector, data["yGalaxies"]))
         # Ignore types below pending making this not working my accident
         if len(xs) < 2:  # type: ignore
-            meds = [np.median(ys)]  # type: ignore
+            meds = [np.nanmedian(ys)]  # type: ignore
         if self.yLims:
             ax.set_ylim(self.yLims[0], self.yLims[1])  # type: ignore
         else:

python/lsst/analysis/tools/actions/plot/skyPlot.py

@@ -335,8 +335,8 @@ def makePlot(
                     maxRa += 1e-5  # There is no reason to pick this number in particular
                 if minDec == maxDec:
                     maxDec += 1e-5  # There is no reason to pick this number in particular
-            med = np.median(colorVals)
-            mad = sigmaMad(colorVals)
+            med = np.nanmedian(colorVals)
+            mad = sigmaMad(colorVals, nan_policy="omit")
             vmin = med - 2 * mad
             vmax = med + 2 * mad
             if self.fixAroundZero:

python/lsst/analysis/tools/analysisPlots/magDiff.py

@@ -0,0 +1,68 @@
+# This file is part of analysis_tools.
+#
+# Developed for the LSST Data Management System.
+# This product includes software developed by the LSST Project
+# (https://www.lsst.org).
+# See the COPYRIGHT file at the top-level directory of this distribution
+# for details of code ownership.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
+from __future__ import annotations
+
+__all__ = ("CModelSubPsfMagMeasSkyGalaxies",)
+
+from ..actions.plot.skyPlot import SkyPlot
+from ..actions.vector import CoaddPlotFlagSelector, GalaxySelector, LoadVector, MagDiff, SnSelector
+from ..interfaces import AnalysisPlot
+
+
+class CModelSubPsfMagMeasSkyGalaxies(AnalysisPlot):
+    """Make a plot showing the difference between the cmodel magnitude and the
+    PSF magnitude. This plot shows the on sky distribution of these values
+    for galaxies.
+    """
+
+    def setDefaults(self):
+        super().setDefaults()
+
+        self.prep.selectors.flagSelector = CoaddPlotFlagSelector()
+        self.prep.selectors.flagSelector.bands = ["g", "r", "i"]
+
+        self.prep.selectors.snSelector = SnSelector()
+        self.prep.selectors.snSelector.bands = ["i"]
+        self.prep.selectors.snSelector.fluxType = "{band}_psfFlux"
+        self.prep.selectors.snSelector.threshold = 100
+
+        self.prep.selectors.galaxySelector = GalaxySelector()
+        self.prep.selectors.galaxySelector.columnKey = "{band}_extendedness"
+
+        # TODO: Can we make these defaults somewhere?
+        self.process.buildActions.xGalaxies = LoadVector()
+        self.process.buildActions.xGalaxies.vectorKey = "coord_ra"
+        self.process.buildActions.yGalaxies = LoadVector()
+        self.process.buildActions.yGalaxies.vectorKey = "coord_dec"
+        self.process.buildActions.galaxyStatMask = SnSelector()
+        self.process.buildActions.galaxyStatMask.fluxType = "{band}_psfFlux"
+
+        self.process.buildActions.zGalaxies = MagDiff()
+        self.process.buildActions.zGalaxies.col1 = "{band}_cModelFlux"
+        self.process.buildActions.zGalaxies.col2 = "{band}_psfFlux"
+
+        self.produce = SkyPlot()
+        self.produce.plotTypes = ["galaxies"]
+        self.produce.plotName = "CModel_sub_PSF_meas_galaxies_{band}"
+        self.produce.xAxisLabel = "R.A. (degrees)"
+        self.produce.yAxisLabel = "Dec. (degrees)"
+        self.produce.zAxisLabel = "CModel - PSF (mmag) (Meas)"
+        self.produce.plotOutlines = False