DM-40768: Stellar photometric repeatability in analysis_tools is not applying defaults correctly #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bechtol
approved these changes
Sep 29, 2023
jeffcarlin
force-pushed
the
tickets/DM-40768
branch
from
0e7fd55
to
5aad4f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a fix to ensure that "PF1" (the fraction of outliers in photometric repeatability) is calculated correctly in analysis_tools. The previous implementation did not actually set the value given in config, so the configured values needed to be moved to a
finalizemethod to ensure that they are properly assigned.