Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39817: Create analysis_tools afterburner for ap_pipe #147

Merged
merged 9 commits into from Oct 4, 2023

Conversation

ebellm
Copy link
Contributor

@ebellm ebellm commented Oct 4, 2023

No description provided.

@ebellm ebellm requested a review from isullivan October 4, 2023 19:10
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes requested.

@@ -0,0 +1,36 @@
from __future__ import annotations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the copyright text block

@@ -0,0 +1,32 @@
from __future__ import annotations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the copyright text block

name="{fakesType}{coaddName}Diff_assocDiaSrc",
storageClass="DataFrame",
dimensions=("visit", "band", "detector"),
deferLoad=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need deferLoad

name="{fakesType}{coaddName}Diff_diaObject",
storageClass="DataFrame",
dimensions=("visit", "band"),
deferLoad=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need deferLoad

@ebellm ebellm merged commit 01ff57b into main Oct 4, 2023
8 checks passed
@ebellm ebellm deleted the tickets/DM-39817 branch October 4, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants