DM-39745: Merge matched difference plot/metric classes #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
force-pushed
the
tickets/DM-39745
branch
from
da41bad
to
129520a
Compare
leeskelvin
reviewed
Nov 3, 2023
Comment on lines
+22
to
+23
| # Doesn't work; interpreted as float | ||
| # atools.matchedRefCModelMagDiff.produce.plot.xLims: [parameters.mag_x_min, parameters.mag_x_max] |
There was a problem hiding this comment.
Does this need to be here for any particular historical reason?
There was a problem hiding this comment.
Sort of; it's a note that this doesn't work even though it should. In this case I ended up preferring to define lims_mag_x in the python block. Anyway, I'm going to address this on a subsequent ticket (DM-41049).
leeskelvin
reviewed
Nov 3, 2023
| optional=False, | ||
| ) | ||
|
|
||
| def finalize(self): | ||
| # Check if it has already been finalized | ||
| if not hasattr(self.process.buildActions, "diff"): | ||
| # Set before MagnitudeScatterPlot.finalize to undo PSF default |
There was a problem hiding this comment.
Missing period at the end of this comment, unless you intend for these two lines to be read as one sentence (I think not).
taranu
force-pushed
the
tickets/DM-39745
branch
from
129520a
to
c72ff9a
Compare
taranu
force-pushed
the
tickets/DM-39745
branch
from
c72ff9a
to
e113a1b
Compare
taranu
force-pushed
the
tickets/DM-39745
branch
from
e113a1b
to
0e2c02b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.