DM-41623: Enabled the plotting of patch boundaries in skyPlot.py #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmullaney
force-pushed
the
tickets/DM-41623
branch
2 times, most recently
from
b094022
to
158c78d
Compare
Comment on lines
217
to
221
| if self.plotOutlines: | ||
| if sumStats is None and "patch" in data.keys(): | ||
| sumStats = generateSummaryStats(data, kwargs["skymap"], plotInfo) | ||
| else: | ||
| sumStats = {} |
There was a problem hiding this comment.
This doesn't maintain the previous behaviour: if self.plotOutlines is False then the None doesn't get converted to an empty dict like it used to. I think you need to do something more like this:
if sumStats is None:
if self.plotOutlines and "patch" in data.keys():
sumStats = generateSummaryStats(data, kwargs["skymap"], plotInfo)
else:
sumStats = {}
There was a problem hiding this comment.
(untested suggestion, but hopefully that makes sense and will more or less work)
There was a problem hiding this comment.
Agreed. I've changed it to what you suggested, and tested it by running coaddQualityExtended.yaml both with plotOutlines=False and plotOutlines=True. Works as expected under both circumstances. Just about to push new version...
jrmullaney
force-pushed
the
tickets/DM-41623
branch
from
158c78d
to
931ec46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.