DM-41934 Add the ability to explicitly set Sasquatch time #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
reviewed
Dec 6, 2023
leeskelvin
reviewed
Dec 6, 2023
leeskelvin
reviewed
Dec 6, 2023
| @@ -212,7 +213,8 @@ class AnalysisBaseConfig(PipelineTaskConfig, pipelineConnections=AnalysisBaseCon | |||
| doc="Which time stamp should be used as the reference timestamp for a " | |||
| "metric in a time series database, valid values are; " | |||
| "reference_package_timestamp, run_timestamp, current_timestamp, " | |||
| "and dataset_timestamp", | |||
| "dataset_timestamp and explicit_timestamp:datetime where datetime is" | |||
| "is given in the form %Y%m%dT%H%M%S%z", | |||
There was a problem hiding this comment.
So, %z is the time zone in format "±HHMM". AFAICT, times uploaded to the Chronograf are in Zulu time, i.e., UTC+0, i.e., GMT. Would that equate to +0000 in this format?
There was a problem hiding this comment.
There was a problem hiding this comment.
You can do +0000 or z which is an explicit carve out, I think because it is such a commonly output format
leeskelvin
reviewed
Dec 6, 2023
leeskelvin
reviewed
Dec 6, 2023
natelust
force-pushed
the
tickets/DM-41934
branch
2 times, most recently
from
b518f0c
to
8837b75
Compare
Add the ability to explicitly set the time Sasquatch will use from the pipeline task or pipeline interfaces. This is done by setting the task config variable timestamp_version, or the pipeline parameter sasquatch_timestamp_version to a value of explicit_timestamp:%Y%m%dT%H%M%S%z
natelust
force-pushed
the
tickets/DM-41934
branch
from
8837b75
to
910b026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to explicitly set the time Sasquatch will use from the pipeline task or pipeline interfaces. This is done by setting the task config variable timestamp_version, or the pipeline parameter sasquatch_timestamp_version to a value of
explicit_timestamp:%Y%m%dT%H%M%S%z