DM-41953: Implement an adaptive binning option for projection plots in analysis_tools #172
Conversation
|
At this stage, the adaptive binning feature has only been added to focalPlanePlot.py. It can be included in skyPlot.py should we wish, but I'd open a new ticket for that. I've kept the commit history here so you can see my thought processes. I can clean it up using an interactive rebase once it's gone through the review process. |
|
I think it would be useful to have something that defaults to points rather than binning in the case of low density. I wonder if it is possible to do both in an efficent manner on the same plot, probably future work. |
Thanks @sr525 for taking a look at this. To clarify - are you ok for me to merge this, then create a new ticket to implement your suggestion for plotting points for low densities? Is this what you meant by "future work"? |
| doc="Number of bins to use within the effective plot ranges along" | ||
| " the spatial directions. If nBins is negative the number of" | ||
| " bins is adapted to the source density, with lower densities" | ||
| " using fewer bins, but with a minimum of abs(nBins).", |
There was a problem hiding this comment.
I think that instead of using negative it would be better to have a config option, something like doUseAdaptiveBinning, that is more explicit and easier to understand at a glance. Then the normal bins config can stay the same and be used for both.
jrmullaney
force-pushed
the
tickets/DM-41953
branch
2 times, most recently
from
b83490c
to
1f1cc34
Compare
jrmullaney
force-pushed
the
tickets/DM-41953
branch
from
1f1cc34
to
676ae9a
Compare
No description provided.