Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42535: Add the old config names back in with a deprecation warning. #185

Merged
merged 1 commit into from Jan 17, 2024

Conversation

sr525
Copy link
Collaborator

@sr525 sr525 commented Jan 17, 2024

No description provided.

Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor wording comment (applies to both).

raColumn = pexConfig.Field[str](
doc="RA column.",
default="coord_ra",
deprecated="This field was replaced with targetRaColumn. Will be removed after v27.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add "with targetRaColumn and is unused. Will..."

@sr525 sr525 merged commit 0f08c40 into main Jan 17, 2024
8 checks passed
@sr525 sr525 deleted the tickets/DM-42535 branch January 17, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants