DM-42224: Add diaSource streak flag metric #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr525
reviewed
Jan 31, 2024
sr525
reviewed
Jan 31, 2024
sr525
reviewed
Jan 31, 2024
sr525
reviewed
Jan 31, 2024
sr525
reviewed
Jan 31, 2024
sr525
reviewed
Jan 31, 2024
sr525
reviewed
Jan 31, 2024
sr525
reviewed
Jan 31, 2024
python/lsst/analysis/tools/atools/diaSourceTableTractMetrics.py
Outdated
Show resolved
Hide resolved
sr525
reviewed
Jan 31, 2024
sr525
reviewed
Jan 31, 2024
python/lsst/analysis/tools/tasks/diaSourceTableTractAnalysis.py
Outdated
Show resolved
Hide resolved
mrawls
force-pushed
the
tickets/DM-42224
branch
5 times, most recently
from
2b03b03
to
cd59606
Compare
|
@sr525 I think this should be all set now, please take another look when you can! |
sr525
reviewed
Feb 6, 2024
| ax.scatter(data[ra], data[dec], s=panel.size, alpha=panel.alpha, marker=".", linewidths=0) | ||
| # TODO DM-42768: implement lists of colors, sizes, alphas, etc. | ||
| # and add better support for multi-panel plots. | ||
| # Right now, color is excluded, each series gets the next default. |
There was a problem hiding this comment.
Another suggestion, but probably for a future ticket. There should probably be some sort of 2d binning for dense data
mrawls
force-pushed
the
tickets/DM-42224
branch
from
6e2c528
to
a82516b
Compare
This counts the number of total 'good' diaSources and the number that fall in a streak or streakCenter region. It also adds support for both DRP and AP column naming schemes so future metrics can more easily read different catalog data products.
turn on atools in the pipeline config, not the task
mrawls
force-pushed
the
tickets/DM-42224
branch
2 times, most recently
from
0e24891
to
6f2fdd8
Compare
mrawls
force-pushed
the
tickets/DM-42224
branch
from
6f2fdd8
to
328d7d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple counter metric for the diaSourceTable_tract data product (produced in DRP Step 5) and an optional DiaSkyPlot to go along with it. It is intended as a basic starting point for adding more streak-flavored metrics to both AP and DRP data products and eventually multi-panel plots (in addition to panels that show multiple selections of points).