DM-42741: Make focalPlaneGeometryPlot look a bit better #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr525
force-pushed
the
tickets/DM-42741
branch
2 times, most recently
from
ee5c772
to
72a6f39
Compare
plazas
approved these changes
Feb 8, 2024
| @@ -343,6 +355,10 @@ def makePlot( | |||
| fig : `matplotlib.figure.Figure` | |||
| The resulting figure. | |||
| """ | |||
|
|
|||
| cmap = mkColormap(["midnightBlue", "lightcyan", "darkgreen"]) | |||
There was a problem hiding this comment.
Why are there 3 options here, and could we add "tableau-colorblind10"?
There was a problem hiding this comment.
The three work together to make the colormap, I do want to move all the plots over to a coloublind friendly set of palates, if these ones aren't already, but I would prefer to change all the plots at once.
| valuesPlot = np.clip(values, vmin, vmax) | ||
|
|
||
| patchCollection = PatchCollection( | ||
| patches, edgecolor="white", cmap=cmap, linewidth=0.5, linestyle=(0, (0.5, 3)) |
There was a problem hiding this comment.
would it be too much to make these options (e.g., edgecolor, linewidth...) configurable too, or is it not worth it?
There was a problem hiding this comment.
I would prefer not to make all of these things configurable. I would like the plots produced to be uniform and not clutter up the code with too many config options.
sr525
force-pushed
the
tickets/DM-42741
branch
from
72a6f39
to
cb410d2
Compare
sr525
force-pushed
the
tickets/DM-42741
branch
from
cb410d2
to
b11cc3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.